Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): optional column number in error pattern #1658

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Feb 14, 2022

If error comes from the full line of code column number is not available.
Ex:

system/STM32H7xx/system_stm32h7xx.c:68: error: unterminated #if
   68 | #if defined(DUAL_CORE) && defined(CORE_CM4)
      |

If error comes from the full line of code column number is not available.
Ex:
system/STM32H7xx/system_stm32h7xx.c:68: error: unterminated #if
   68 | #if defined(DUAL_CORE) && defined(CORE_CM4)
      |

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm requested a review from ABOSTM February 14, 2022 10:24
@fpistm fpistm added the Fix label Feb 14, 2022
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Feb 14, 2022
@fpistm fpistm added this to the 2.3.0 milestone Feb 14, 2022
STM32 core based on ST HAL automation moved this from In progress to Reviewer approved Feb 14, 2022
@fpistm fpistm merged commit 3602dda into stm32duino:main Feb 14, 2022
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Feb 14, 2022
@fpistm fpistm deleted the cli_issue branch February 14, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants