Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAL legacy support #1710

Merged
merged 16 commits into from
May 11, 2022
Merged

HAL legacy support #1710

merged 16 commits into from
May 11, 2022

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented May 5, 2022 •
edited

This PR introduce support of HAL Legacy drivers and enable HAL Ethernet legacy support for the Nucleo F429ZI.

Note: Several scripts have been updated to reach this and some fixes have been done during this PR development.

@fpistm fpistm added this to the 2.3.0 milestone May 5, 2022
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation May 5, 2022
@fpistm fpistm requested a review from ABOSTM May 10, 2022 07:50
@fpistm fpistm assigned fpistm and unassigned ABOSTM May 10, 2022
ABOSTM
ABOSTM requested changes May 11, 2022
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the 12th commit:
"variant(G4): update properly against open pin data DB 6.0.50"

CI/update/stm32variant.py Show resolved Hide resolved
variants/STM32F0xx/F042C(4-6)(T-U)/PeripheralPins.c Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from In progress to Needs review May 11, 2022
fpistm added 16 commits May 11, 2022 11:30
@fpistm
ci(stm32wrapper): render files only once
9f59cfd 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
ci(stm32wrapper): add HAL legacy support
23bd927 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
ci(stm32variant): removed unused module
4caa2c0 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
ci: rename pathlib_ext to common_ext
dc55441 
as functions are more than PathLib extension and new ones
will be added.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
ci: move common functions to common_ext library
27639d3 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
ci(stm32variant): ensure to use correct default branch
a1c2b5d 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
ci(stm32variant): use common function
db068f3 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
ci(stm32variant): add legacy HAL module management
f801f71 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
fix(stm32variant): ensure GPIO file is the correct one
d7462b1 
Example for U5, file was the one for "LPBAMLPGPIO1"

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
ci(stm32variant): list directories change
9ff28e6 
to warn user about new directories and ones to remove.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
lib(SrcWrapper): update HAL wrapped files with legacy
e3d97bb 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
variant(G4): update properly against open pin data DB 6.0.50
1b75c2a 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
variant: update generated files with HAL legacy module definitions
edfff68 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
variant: update custom files with HAL legacy module definitions
7268818 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
feat(F4): enable HAL Ethernet legacy
274cea0 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
fix: use HAL ethernet legacy for Nucleo F429ZI
a018a5f 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Copy link
Member Author

fpistm commented May 11, 2022

Typo fixed in the commit message.

@fpistm fpistm requested a review from ABOSTM May 11, 2022 15:56
ABOSTM
ABOSTM approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved May 11, 2022
@fpistm fpistm merged commit 437cbed into stm32duino:main May 11, 2022
STM32 core based on ST HAL automation moved this from Reviewer approved to Done May 11, 2022
@fpistm fpistm deleted the HAL_Legacy branch May 11, 2022 18:20
@fpistm fpistm mentioned this pull request May 16, 2022
Open
@fpistm fpistm mentioned this pull request Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABOSTM ABOSTM ABOSTM approved these changes

Assignees

@fpistm fpistm

Labels
Enhancement Fix
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fpistm @ABOSTM