STM32F1 merge other (BluePill and Maple Mini) #61

fpistm · 2017-07-11T14:45:35Z

Second part of the Arduino_Core_STM32F1 merge. #20 --> now covered by #213 except for USB part

Include above variant from #45

BLUEPILL-F103C8
MAPLEMINI-F103CB

Need some review around USB (based on contributor feedback)
~~Need review upload menu (avoid maple one for BP)~~ Covered by #213
...

RickKimball · 2017-08-23T01:39:22Z

So I'm looking at this new branch and it doesn't seem like any of the USB issues I mentioned in #45 have been addressed. Is this something that is being looked at?

RickKimball · 2017-08-23T01:41:34Z

BTW: The default upload method of "Maple bootloader" is probably a bad pick for the Other boards. Most people are using a bluepill according to the latest Poll on stm32duino. Even those who are using a maple mini typically update the bootloader to the latest one because it is smaller in flash size and works better in general.

fpistm · 2017-08-23T06:22:59Z

@RickKimball, it's ongoing, they are lot of work/review around USB and this need some time. As you can see, I've rebased regularly this PR.
About the bootloader, you talk about the fact BP has the Maple bootloader in the menu ?
It is plaaned to split Other menu to be able to have correct upoad method and also be able to have some customization as asked in #59

Upload method Bootloader, Serial and BMP added. USBSerial class added because is required by bootloader. Signed-off-by: fpr <fabien.perroquin@wi6labs.com>

Signed-off-by: fpr <fabien.perroquin@wi6labs.com>

Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>

ghost · 2017-09-19T11:46:12Z

boards.txt

+Other.menu.upload_method.STLinkMethod=STLink
+Other.menu.upload_method.STLinkMethod.upload.protocol=STLink
+Other.menu.upload_method.STLinkMethod.upload.tool=stlink_upload
+Other.menu.upload_method.STLinkMethod.build.upload_flags=-DSERIAL_USB


Move STLink method before DFUUploadMethod. STLink will be the default Upload method.

ghost · 2017-09-19T11:48:36Z

variants/MAPLEMINI_F103CB/variant.h

+#define SS3                     10
+#define MOSI                    6
+#define MISO                    5
+#define SCK                     4


SPI configuration should be updated.

Testato · 2017-12-04T14:43:55Z

@cparata
this is the issue we talked about at the Maker Faire Rome 2017.

The official merge of Bluepill (and all the classic board with F103C8 / CB) is of vital importance given the commercial success of these boards, all the users of Roger's core have a Bluepill / Maplemini at home

Official support for Bluepill has been mentioned for some time in the core homepage, but never merged.
https://github.com/stm32duino/Arduino_Core_STM32#next-release

lacklustrlabs · 2018-01-12T10:36:53Z

I have successfully tested this with maple mini + STLink and I would love to see this merged.
If there is a problem with USB, couldn't that be added/fixed at a later stage?

fpistm · 2018-01-12T11:04:41Z

I'm currently thinking to add BP and MM without USB support.
And as you mentioned review USB later so only STLink upload and Serial via a FTDI will be available.

… works on a maple mini (STLink upload, UART2).

fpistm · 2018-01-30T22:28:38Z

I will provide the light version end of the week.

lacklustrlabs · 2018-01-31T09:37:02Z

Feel free to copy&paste from my temporary BP&MM rebase branch. I think I was too heavy handed with the USB stuff so I won't make a PR with it.

fpistm mentioned this pull request Jul 11, 2017

STM32F1 merged (replaced by #61) #45

Closed

fpistm force-pushed the STM32F1_merge_Other branch 2 times, most recently from 93d8db4 to addd3ea Compare July 12, 2017 14:44

fpistm changed the title ~~STM32F1 merge other (BluePill Maple Mini and and STM32F1VLDisco~~ STM32F1 merge other (BluePill Maple Mini and and STM32F1VLDisco) Jul 12, 2017

fpistm added enhancement New feature or request help wanted 🙏 Extra attention is needed labels Jul 12, 2017

fpistm requested a review from a user July 12, 2017 14:45

fpistm assigned fpistm and ghost Jul 12, 2017

fpistm force-pushed the STM32F1_merge_Other branch from addd3ea to 50d0ca3 Compare July 12, 2017 15:27

fpistm force-pushed the STM32F1_merge_Other branch from 50d0ca3 to 17fe6ab Compare August 1, 2017 12:31

fpistm changed the title ~~STM32F1 merge other (BluePill Maple Mini and and STM32F1VLDisco)~~ STM32F1 merge other (BluePill Maple Mini and) Aug 2, 2017

fpistm changed the title ~~STM32F1 merge other (BluePill Maple Mini and)~~ STM32F1 merge other (BluePill and Maple Mini) Aug 2, 2017

fpistm force-pushed the STM32F1_merge_Other branch 3 times, most recently from 40275c7 to c7678b9 Compare August 21, 2017 15:08

fpistm force-pushed the STM32F1_merge_Other branch 2 times, most recently from 0216236 to f85ebb5 Compare August 30, 2017 14:39

fpistm added this to the Next release milestone Aug 31, 2017

fpistm and others added 8 commits September 1, 2017 10:29

BluePill F103C8 variant added.

e737f89

Upload method Bootloader, Serial and BMP added. USBSerial class added because is required by bootloader. Signed-off-by: fpr <fabien.perroquin@wi6labs.com>

Maple Mini STM32F103CB added.

69c09fb

Signed-off-by: fpr <fabien.perroquin@wi6labs.com>

Aligns configuration with master

5ef765c

Signed-off-by: fpr <fabien.perroquin@wi6labs.com>

Add extra include path for USB CDC

1902beb

Signed-off-by: fpr <fabien.perroquin@wi6labs.com>

Add USB IRQHandler for BluePill and MapleMini variants

47ca5c2

Signed-off-by: fpr <fabien.perroquin@wi6labs.com>

BluePill pin mapping reordered

f3b6c46

Signed-off-by: fpr <fabien.perroquin@wi6labs.com>

Add missing {build.upload_flags}

dc7f4d5

Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>

Align Pins name and pins index after merged of stm32duino#83

6ec7b0b

Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>

fpistm added 3 commits September 1, 2017 10:29

Update after update for HAL drivers for F1 (stm32duino#78)

66bb1db

Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>

Update after the AF update for STM32F1

8cc1fd2

Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>

Remove SCLK definition

cf38a1f

Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>

fpistm force-pushed the STM32F1_merge_Other branch from f85ebb5 to cf38a1f Compare September 1, 2017 08:33

ghost reviewed Sep 19, 2017

View reviewed changes

fpistm mentioned this pull request Dec 4, 2017

New Board: STM32F030F4 Demo Board #165

Closed

lacklustrlabs added a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Jan 19, 2018

Temporary quick and dirty rebase of stm32duino#61, Blinky with serial…

515fb5a

… works on a maple mini (STLink upload, UART2).

lacklustrlabs added a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Jan 23, 2018

Temporary quick and dirty rebase of stm32duino#61, Blinky with serial…

66b2359

… works on a maple mini (STLink upload, UART2).

lacklustrlabs added a commit to lacklustrlabs/Arduino_Core_STM32 that referenced this pull request Jan 29, 2018

stm32duino#61 Rebased. MM & BP blinky tested with STLink and Serial2

8a35b47

fpistm added new variant Add support of new bard and removed enhancement New feature or request labels Jan 31, 2018

fpistm mentioned this pull request Jan 31, 2018

BluePill and MapleMini support (No USB) #213

Merged

fpistm added abandoned No more work on this and removed help wanted 🙏 Extra attention is needed labels Jan 31, 2018

fpistm removed this from the Next release milestone Feb 1, 2018

fpistm mentioned this pull request Mar 6, 2018

USB features #222

Closed

2 tasks

fpistm closed this Mar 6, 2018

fpistm deleted the STM32F1_merge_Other branch May 29, 2019 14:23

fpistm mentioned this pull request Jun 6, 2023

gh pr list do not show some PR cli/cli#7538

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STM32F1 merge other (BluePill and Maple Mini) #61

STM32F1 merge other (BluePill and Maple Mini) #61

fpistm commented Jul 11, 2017 •

edited

Loading

RickKimball commented Aug 23, 2017

RickKimball commented Aug 23, 2017

fpistm commented Aug 23, 2017

ghost Sep 19, 2017

ghost Sep 19, 2017

Testato commented Dec 4, 2017 •

edited

Loading

lacklustrlabs commented Jan 12, 2018

fpistm commented Jan 12, 2018

fpistm commented Jan 30, 2018 •

edited

Loading

lacklustrlabs commented Jan 31, 2018

STM32F1 merge other (BluePill and Maple Mini) #61

STM32F1 merge other (BluePill and Maple Mini) #61

Conversation

fpistm commented Jul 11, 2017 • edited Loading

RickKimball commented Aug 23, 2017

RickKimball commented Aug 23, 2017

fpistm commented Aug 23, 2017

ghost Sep 19, 2017

Choose a reason for hiding this comment

ghost Sep 19, 2017

Choose a reason for hiding this comment

Testato commented Dec 4, 2017 • edited Loading

lacklustrlabs commented Jan 12, 2018

fpistm commented Jan 12, 2018

fpistm commented Jan 30, 2018 • edited Loading

lacklustrlabs commented Jan 31, 2018

fpistm commented Jul 11, 2017 •

edited

Loading

Testato commented Dec 4, 2017 •

edited

Loading

fpistm commented Jan 30, 2018 •

edited

Loading