Add OEM field for ComputerSystem #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcginnis
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Thanks, this looks good. You then should be able to follow the pattern used for the event service to transform a standard ComputerSystem to an OEM one. That can happen either here in the oem/ folder, or you can define your own local structs. Or just directly access the data out of the OEM field, of course.
|
Thanks, that was quick! I can see that in this repo the structs are generated from Redfish schema. I'm thinking whether the newly generated structs won't clear this field and how to preserve it from being overridden? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add
ComputerSystem.OEMfield as HPE and Dell provide it.It's not part of the Redfish API schema so not sure if this is the right way to do it.