-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to get the RedundancySet for a given Redundancy group in the Power resource #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please expose this by adding an accessor method so it is consistent with the other object/related-object acccess.
For example:
https://github.com/stmcginnis/gofish/blob/main/redfish/power.go#L425
Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - just a couple minor things.
Hey @stmcginnis, I'm unsure if I made this function consistent with your other object/related-object access as I could not use the
Hitting those links gives back the same response as My goal is to get the |
Yep, that makes sense. Those are jsonpath links, so in this case they are self-referential. I think the approach makes sense. |
Thanks for the quick feedback. I have made the adjustments and added more to the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates - looks good!
This change makes it so we can access the
RedundancySet
param, which contains all actual Power Supplies vs what is listed in.PowerSupplies
as that can contain anything in the PSU slots, which sometimes are fans and not actual power supplies.