Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug in camel case conversion #11

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Fix Bug in camel case conversion #11

merged 2 commits into from
Mar 28, 2023

Conversation

ohkinozomu
Copy link
Contributor

Close #9

There may be software that depends on the bug, so I think a warning is needed when this patch is released.

@stoewer stoewer force-pushed the fix-Bug-in-camel-case-conversion branch from 839d0ff to 7faaf59 Compare March 27, 2023 23:33
stoewer
stoewer requested changes Mar 27, 2023
View reviewed changes
Copy link
Owner

@stoewer stoewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this fix. The code looks good but I think it would be beneficial to add another test case.

so I think a warning is needed when this patch is released

Sounds good, I'll add a warning

camel_test.go Show resolved Hide resolved
camel_test.go Show resolved Hide resolved
@stoewer stoewer merged commit 579df9a into stoewer:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoewer stoewer stoewer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in camel case conversion
2 participants
@ohkinozomu @stoewer