Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect mod date being used in the scanner? #32

Closed
derwin12 opened this issue Apr 12, 2022 · 5 comments
Closed

Incorrect mod date being used in the scanner? #32

derwin12 opened this issue Apr 12, 2022 · 5 comments

Comments

@derwin12
Copy link

Again a noob with your tool but going thru the logs and here is just one example of confusing dates/errors:

Fixed Game Created Time          index=0398 name='Elvira's House Of Horro' game.createdAt '21-08-21 18:00:00' < maxCreatedAt '15-03-22 07:16:10'  
Fixed Game Updated Time Too Low  index=0398 name='Elvira's House Of Horro' game.updatedAt '21-08-21 18:00:00' < maxUpdatedAt '15-03-22 07:16:15'  
Fixed Wrong Url                  index=0398 name='Elvira's House Of Horro' type=TableFiles url=https://vpuniverse.com/forums/files/file/7336-elvira-limited-edition/  

So from the log, it would appear that the file I have is out of date. I have '2021 and it says there is a new one from '2022
The file is found at vpuniverse. That file is '2021. So where is this '2022 date coming from that would be flagging the table to be out of date?

image

Looking at the vps - it would appear to be from the backglass? Is that the what is happening? Is the scanner checking against the wrong date?

image

@stojy
Copy link
Owner

stojy commented Apr 13, 2022

Definitely not a noob question. There's a few things going on here.

Firstly, the importer feature you're using only checks the online source from VPS. It doesn't cross reference that information against your local file collection to alert for any 'out of date' files. This feature is effectively the next thing on my list (refer #25).

Until I get around to implementing #25, the recommended usage is to use importer to identify 'out of date' files by applying an 'updated from' in the filter that matches the last time you updated yoru collection with new content. For example..
image

Secondly, in order for the 'updated from' to work correctly I've had to sanitize some of the data from the VPS feed. Whilst it's an awesome source of data, it unfortunately has a few 'quirks' where the data isn't quite correct. You can see a summary in the statistics tab, for example..
image

It's exactly was you've described, the top level (game) has the 'last updated' set as 29/11/21.. which isn't correct because the backglass was updated on 15/3/22. So in order to make the ClrVpin 'updated from' feature to work I've made some tweaks to the data feed.

FYI, I've had to do similar fixes for other content fields like invalid URLs.

And lastly, to make it clear which content type(s) (e.g. backglass, table, dmd, etc) have actually been updated relative to the 'updated from' criteria, it's been marked in orange color. For example..
image

@stojy
Copy link
Owner

stojy commented Apr 13, 2022

Perhaps if the the 'fixed game XXXX' logs are confusing.. I might just drop them from the logs tab. Especially as they're not particularly useful to the end user anyway.

@derwin12
Copy link
Author

I was going thru the log portion .. since it appears to be quite helpful .. using a grep to find files that were newer than what I had. I understand your having to battle with the vps data. Are you using the google sheet (is that still available) or their newer web site?
Having over 500 games I thought this would be the best plan of attack.
Going with the top filter for update since is a bit unwildly(sp) when I am 3+ years out of date and moving from .vpt to vpx :-)
(amazing how many of my authored tables allknowing2012 - have been re-authored now in vpx -- nice to see)

@stojy
Copy link
Owner

stojy commented Apr 13, 2022

Seeing as you're finding the logs useful, I'll make a note to mark those VPS sanitising logs as 'info only' seeing as they don't add any real user benefit.

The VPS google sheets is now obsolete and no longer maintained I believe. It's been replaced by the json feed used by the newer VPS web site, which is the the exact same feed I use for ClrVpin (and subsequently sanitize) as they have thankfully open sourced it :)

I'll be sure to check out some of your tables.

@stojy
Copy link
Owner

stojy commented Apr 13, 2022

Regarding your 3yr old collection, you could in theory set the 'updated form' to 2019 and then you would see just those tables that have been updated since. Assuming of course the VPS feed is 100% correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants