Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply port forwarding service for fixing argocd client connection time out in canary test #116

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

xiangjingli
Copy link
Collaborator

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
@xiangjingli xiangjingli requested a review from rokej June 2, 2021 17:54
@openshift-ci openshift-ci bot added the approved label Jun 2, 2021
@xiangjingli
Copy link
Collaborator Author

/test unit

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
Copy link
Collaborator

@rokej rokej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiangjingli Thanks!

@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rokej, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Jun 2, 2021
@xiangjingli
Copy link
Collaborator Author

/retest

@xiangjingli
Copy link
Collaborator Author

/test unit

@openshift-merge-robot openshift-merge-robot merged commit 3c2db78 into main Jun 2, 2021
@mikeshng mikeshng deleted the newArgoCDTest branch May 2, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants