Only detect local-cluster secret to be imported to different argocd s… #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver NS Signed-off-by: Xiangjing Li <xiangli@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiangjingli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erver NS
Signed-off-by: Xiangjing Li xiangli@redhat.com
It turns out there are various kinds of non-ocp K8s clusters imported into Canary test env like Azure, GKE etc. Non OCP clusters don't have the cluster secrets generated.
The fix is detect local-cluster secret to be imported to different argocd server NameSpaces based on the gitopscluster CR spec changes. local-cluster is OCP cluster for sure.