Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode app chn apis #163

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Hardcode app chn apis #163

merged 1 commit into from
Apr 1, 2022

Conversation

mikeshng
Copy link
Collaborator

@mikeshng mikeshng commented Apr 1, 2022

Signed-off-by: Mike Ng ming@redhat.com

Signed-off-by: Mike Ng <ming@redhat.com>
@mikeshng
Copy link
Collaborator Author

mikeshng commented Apr 1, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 1, 2022

@mikeshng: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Apr 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6b5808a into main Apr 1, 2022
@mikeshng mikeshng deleted the remove-app-chn-dep branch April 1, 2022 18:28
lennysgarage pushed a commit that referenced this pull request Jun 30, 2022
Signed-off-by: Mike Ng <ming@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants