Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README steps to use proper order and an AppStudio perspective #36

Merged
merged 6 commits into from
Apr 14, 2022

Conversation

chrisahl
Copy link
Contributor

@chrisahl
Copy link
Contributor Author

/hold

@leena-jawale
Copy link
Collaborator

Looks good to me. Just one comment - can we be consistent with either oc or kubectl ?

Signed-off-by: Chris Ahl <cahl@redhat.com>
Signed-off-by: Chris Ahl <cahl@redhat.com>
Signed-off-by: Chris Ahl <cahl@redhat.com>
@leena-jawale
Copy link
Collaborator

/lgtm

Signed-off-by: Chris Ahl <cahl@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Apr 14, 2022
@chrisahl
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot added the lgtm label Apr 14, 2022
@chrisahl
Copy link
Contributor Author

/hold

Signed-off-by: Chris Ahl <cahl@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Apr 14, 2022
@chrisahl
Copy link
Contributor Author

/unhold

@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@leena-jawale
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisahl, leena-jawale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chrisahl,leena-jawale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8615b35 into stolostron:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants