Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset the namespace for cluster scoped resources #133

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Aug 15, 2024

Relates:
https://issues.redhat.com/browse/ACM-13346

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Copy link

sonarcloud bot commented Aug 15, 2024

Copy link
Contributor

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek,mprahl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d279388 into stolostron:main Aug 15, 2024
5 checks passed
@mprahl
Copy link
Contributor Author

mprahl commented Aug 15, 2024

/cherry-pick release-2.11

@mprahl
Copy link
Contributor Author

mprahl commented Aug 15, 2024

/cherry-pick release-2.10

@mprahl
Copy link
Contributor Author

mprahl commented Aug 15, 2024

/cherry-pick release-2.9

@openshift-cherrypick-robot

@mprahl: new pull request created: #135

In response to this:

/cherry-pick release-2.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mprahl: new pull request created: #136

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mprahl: new pull request created: #137

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants