Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy to install oadp #1448

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Conversation

birsanv
Copy link
Contributor

@birsanv birsanv commented Apr 16, 2024

Description

Create a policy to wrap up the installation of the oadp operator

Related Issue

https://issues.redhat.com/browse/ACM-10890

Changes Made

Created a new Policy which can be used to install OADP.
The policy does not install OADP if

  • this is an STS enabled cluster
  • the user sets oadp-manual=true label on the local-cluster hub resource

In the screen cap below, the oadp-manual=true label is set on the local-cluster hub resource so the policy doesn't try to create the operator

The policy is disabled for now and I am keeping the chart resources used to install the OADP operator; once I can test the policy being packaged with the chart I will enable it and replace the chart resources

Screenshots (if applicable)

Screenshot 2024-04-16 at 4 09 53 PM

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
@birsanv
Copy link
Contributor Author

birsanv commented Apr 16, 2024

/test test-unit

Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@birsanv
Copy link
Contributor Author

birsanv commented Apr 16, 2024

/cc @tesshuflower

@birsanv
Copy link
Contributor Author

birsanv commented Apr 16, 2024

/cc @dislbenn

@openshift-ci openshift-ci bot requested a review from dislbenn April 16, 2024 21:20
@dislbenn
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, dislbenn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 34ef73a into stolostron:main Apr 17, 2024
6 checks passed
@birsanv birsanv deleted the vb_policy branch April 17, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants