Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: code optimisations and warnings fixes #36

Closed
wants to merge 3 commits into from

Conversation

wthrajat
Copy link

Fixes various clippy code warnings by removing unnecessary stuff to optimize the codebase.

These includes warnings about operator precedence, redundant field names in struct initialization, single-character string constant used as pattern, unnecessary casting integer literal to u8, reference immediately dereferenced by the compiler, useless conversions, unnecessary let, return statements, closures etc.

Detailed clippy logs can be found here

Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
@SlavikBaranov
Copy link
Contributor

Hey @wthrajat! Thanks for doing this work, it's really helpful!
We're preparing 0.13 release with a lot of changes and some of your changes are conflicting with our internal version.
We'll merge your PR in 0.13, I'll leave it open in the meantime.

Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
@wthrajat
Copy link
Author

@SlavikBaranov cool! While at it, I added some more clints and fixes and a minor rust-doc lint error URL is not a hyperlink.

@Sild
Copy link
Collaborator

Sild commented Oct 30, 2024

Quite outdated already =(

Our pipelines check such things in latest revision

@Sild Sild closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants