Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu):assert failed on oldv <= dpn_->max_i at pack_int.cpp:337 (#1610) #1627

Merged
merged 6 commits into from
Apr 27, 2023

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented Apr 26, 2023

Summary about this PR

Issue Number: close #1610
Issue Number: close #1620
Issue Number: close #1617

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@konghaiya
Copy link
Collaborator Author

image

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 68.59% and project coverage change: -0.01 ⚠️

Comparison is base (ba8cead) 55.22% compared to head (78e5590) 55.22%.

❗ Current head 78e5590 differs from pull request most recent head b955265. Consider uploading reports for the commit b955265 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1627      +/-   ##
===================================================
- Coverage            55.22%   55.22%   -0.01%     
===================================================
  Files                 2031     2031              
  Lines               431415   431436      +21     
===================================================
+ Hits                238246   238252       +6     
- Misses              193169   193184      +15     
Impacted Files Coverage Δ
storage/tianmu/data/pack_str.h 90.69% <ø> (ø)
storage/tianmu/executor/merge_operator.cpp 91.83% <0.00%> (+5.29%) ⬆️
storage/tianmu/handler/ha_tianmu.cpp 51.51% <ø> (ø)
storage/tianmu/vc/tianmu_attr.cpp 74.22% <33.33%> (+0.02%) ⬆️
storage/tianmu/data/pack_str.cpp 65.21% <56.66%> (-0.95%) ⬇️
storage/tianmu/data/pack_int.cpp 68.63% <69.86%> (-1.86%) ⬇️
storage/tianmu/core/delta_table.cpp 56.52% <100.00%> (ø)
storage/tianmu/core/engine.cpp 67.06% <100.00%> (+3.06%) ⬆️
storage/tianmu/core/tianmu_table.cpp 67.48% <100.00%> (+0.03%) ⬆️
storage/tianmu/data/pack.cpp 63.63% <100.00%> (+1.37%) ⬆️
... and 1 more

... and 52 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mergify mergify bot merged commit 70f15f1 into stoneatom:stonedb-5.7-dev Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
3 participants