Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(develop-guide): modify method for compile stonedb using docker #1768

Conversation

Dysprosium0626
Copy link
Contributor

  1. change the version of the stonedb from 5.6 to 5.7 in docs.
  2. list both manual install and automatic install in docs.
  3. update the reference in zh-doc to a valid one:
    previous: 可以参考:StoneDB快速部署手册
    now: 可以参考:StoneDB快速部署手册

Summary about this PR

Issue Number: close #1644

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

1. change the version of the stonedb from 5.6 to 5.7 in docs.
2. list both manual install and automatic install in docs.
3. update the reference in zh-doc to a valid one:
可以参考:[StoneDB快速部署手册](https://stonedb.io/zh/docs/getting-started/quick-deployment)
可以参考:[StoneDB快速部署手册](https://stonedb.io/zh/docs/quick-deployment)
@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

This pull request's title should follow requirements next. @Dysprosium0626 please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@Nliver Nliver requested review from Nliver and haitaoguan May 12, 2023 03:21
@Nliver Nliver added the PR-docs docs for pull request label May 12, 2023
@Nliver Nliver added this to the StoneDB_5.7_v1.0.4 milestone May 12, 2023
Copy link
Collaborator

@Nliver Nliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nliver
Copy link
Collaborator

Nliver commented May 12, 2023

Nice Job~ @Dysprosium0626

@Nliver Nliver requested a review from davidshiz May 12, 2023 03:31
@mergify mergify bot merged commit 65585be into stoneatom:stonedb-5.7-dev May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-docs docs for pull request
Projects
Development

Successfully merging this pull request may close these issues.

docs: compile stoneDB in a docker container Chinese and English inconsistent
3 participants