Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): The outermost query returned wrong result #1931 #1936

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

Double0101
Copy link
Collaborator

Cause:
Query execute by join->exec().
Solution:
Solve limit=0 in tianmu, and fix crash in compile which
refer to issue#1394. Then execute this query in tianmu.

Summary about this PR

Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

Cause:
  Query execute by join->exec().
Solution:
  Solve limit=0 in tianmu, and fix crash in compile which
refer to issue#1394. Then execute this query in tianmu.
@Double0101
Copy link
Collaborator Author

[ 99%] tianmu.issue1876                         w7 [ pass ]  1180619
[100%] shutdown_report                          w0 [ pass ]       
--------------------------------------------------------------------------
The servers were restarted 21 times
Spent 1835.439 of 1245 seconds executing testcases

Completed: All 278 tests were successful.

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jul 12, 2023
@Double0101 Double0101 self-assigned this Jul 12, 2023
@RingsC RingsC merged commit 4b712ac into stoneatom:stonedb-5.7-dev Jul 13, 2023
2 of 4 checks passed
@Double0101 Double0101 deleted the out-query-wrong branch July 19, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants