fix(dev-portal): fix broken hash router links #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EdVinyard
approved these changes
Jan 4, 2024
| return ( | ||
| <Box | ||
| as={LinkComponent} | ||
| to={makeSlugAbsoluteRoute && !/^\//.test(item.slug) ? `/${item.slug}` : item.slug} |
There was a problem hiding this comment.
It took me a minute to find this change, so I'm just marking it for other reviewers.
Is there an advantage to using a regular expression here instead of !item.slug.startsWith('/')?
There was a problem hiding this comment.
old habits die hard
daniel-white
force-pushed
the
fix/dev-portal-hash-route
branch
from
cedb6b6
to
438a6f2
Compare
daniel-white
force-pushed
the
fix/dev-portal-hash-route
branch
from
438a6f2
to
3615963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using elements-dev-portal and the hash router, a custom toc with slugs would result in a broken page. this fixes the route matching and makes the routes absolute