Skip to content

fix(mergeallof): make sure fragment is fully merged #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2022

Conversation

dotslashderek
Copy link
Contributor

Right now we merge on a fragment at most twice; we have some that require more merge operations to
be fully merged.

Motivation and Context

Issue 10745 (platform) shows that some schemas have a larger allOf nesting tree than we're currently accounting for - we'll cycle through an individual fragment either once or twice (if allOf(s) are still detected) but won't try again after that.

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Right now we merge on a fragment at most twice; we have some that require more merge operations to
be fully merged.
@dotslashderek dotslashderek self-assigned this May 16, 2022
@dotslashderek dotslashderek requested review from jasonmgillhub, Amjcraft and mmiask and removed request for jasonmgillhub and mmiask May 16, 2022 03:24
Copy link

@Amjcraft Amjcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to trust you here. That ref resolver function is a little hard to read.

I feel this should probably be handled by the _mergeAllOf. Instead of the loop here. But it'll work for a quick fix.

@dotslashderek dotslashderek merged commit 3fb8ae0 into master May 17, 2022
@dotslashderek dotslashderek deleted the fix/10745-allOf-improper-display branch May 17, 2022 11:45
@github-actions
Copy link

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants