Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better-ajv-errors is utterly slow under certain circumstances #455

Closed
P0lip opened this issue Aug 14, 2019 · 1 comment
Closed

better-ajv-errors is utterly slow under certain circumstances #455

P0lip opened this issue Aug 14, 2019 · 1 comment
Assignees
@P0lip
Labels
t/bug Something isn't working

Comments

@P0lip
Copy link
Contributor

P0lip commented Aug 14, 2019

Forgot about this one.
Studio has no better-ajv-errors at all for now, and here is why.

before_better
(yes, you see it right, 15 seconds)
The vast chunk of time is spent on parsing.

After (without better-ajv-errors):
after_better

The potential solution would be to swap json-to-ast parser used in better-ajv-errors with our alternate version of jsonc-parser.
@P0lip P0lip added the t/bug Something isn't working label Aug 14, 2019
@P0lip P0lip self-assigned this Aug 14, 2019
@philsturgeon philsturgeon added this to the Sept '19 milestone Sep 2, 2019
@torifat torifat mentioned this issue Sep 10, 2019
Closed
@P0lip P0lip removed this from the Sept '19 milestone May 14, 2020
@P0lip P0lip mentioned this issue Jun 17, 2020
Merged
4 tasks
@P0lip
Copy link
Contributor Author

P0lip commented Jul 9, 2020

Fixed in #1236

@P0lip P0lip closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@P0lip P0lip

Labels
t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philsturgeon @P0lip