docs: identify the schema used for Yaml 1.2 tag resolution #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
previously approved these changes
Apr 1, 2020
docs/guides/javascript.md
Outdated
| @@ -23,6 +23,7 @@ spectral | |||
| ``` | |||
|
|
|||
| Please note that by default Spectral supports YAML 1.2 with merge keys extension. | |||
| As recommended by the [spec](https://yaml.org/spec/1.2/spec.html#id2804923), tags are resolved according to the "Core schema". | |||
There was a problem hiding this comment.
Suggested change
| As recommended by the [spec](https://yaml.org/spec/1.2/spec.html#id2804923), tags are resolved according to the "Core schema". | |
| As recommended by the [spec](https://yaml.org/spec/1.2/spec.html#id2804923), tags are resolved according to the "Core Schema". |
There was a problem hiding this comment.
Honestly though, YAML spec isn't clear about the schema 😅.
https://medium.com/@P0lip/yaml-is-great-but-dont-use-it-2d02a60181ab section 6.
P0lip
changed the title
P0lip
reviewed
Apr 1, 2020
| @@ -23,6 +23,7 @@ spectral | |||
| ``` | |||
|
|
|||
| Please note that by default Spectral supports YAML 1.2 with merge keys extension. | |||
| As recommended by the [spec](https://yaml.org/spec/1.2/spec.html#id2804923), tags are resolved according to the "Core Schema". | |||
There was a problem hiding this comment.
On a slightly unrelated note - we could move these 2 sentences elsewhere in future, to some more general document.
philsturgeon
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #936
Checklist
Does this PR introduce a breaking change?