Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle failure if branch not pushed #175

Merged
merged 21 commits into from
Jun 10, 2020
Merged

Handle failure if branch not pushed #175

merged 21 commits into from
Jun 10, 2020

Conversation

aramnhammer
Copy link
Collaborator

zazu dev review should check for dirty working tree and push if the branch has not been pushed

Fixes #161

aramnhammer and others added 7 commits June 4, 2020 23:55
@aramnhammer
check working tree and push before opening review
281700d 
\n(feature/161_handle_failure_if_branch_not_pushed)
@stopthatcow
Merge branch 'develop' into feature/161_handle_failure_if_branch_not_…
dddff3b 
…pushed
@aramnhammer
changed dirty condition stdout, wrapped error in str(), changed name …
74055db 
…of status variable to dirty

\n(feature/161_handle_failure_if_branch_not_pushed)
@aramnhammer
missing paren
6ac9c2f 
\n(feature/161_handle_failure_if_branch_not_pushed)
@aramnhammer
Merge branch 'feature/161_handle_failure_if_branch_not_pushed' of git…
90ee32b 
…hub.com:stopthatcow/zazu into feature/161_handle_failure_if_branch_not_pushed
@stopthatcow
Merge branch 'develop' into feature/161_handle_failure_if_branch_not_…
8b18de6 
…pushed
@stopthatcow
Merge branch 'develop' into feature/161_handle_failure_if_branch_not_…
804737e 
…pushed
stopthatcow
stopthatcow reviewed Jun 6, 2020
View reviewed changes
zazu/dev/commands.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 6, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 5b70c0e on feature/161_handle_failure_if_branch_not_pushed into c3be852 on develop.

stopthatcow
stopthatcow requested changes Jun 7, 2020
View reviewed changes
tests/test_dev.py Show resolved Hide resolved
tests/test_dev.py Outdated Show resolved Hide resolved
tests/test_dev.py Outdated Show resolved Hide resolved
tests/test_dev.py Outdated Show resolved Hide resolved
zazu/dev/commands.py Outdated Show resolved Hide resolved
tests/test_dev.py Outdated Show resolved Hide resolved
tests/test_dev.py Outdated Show resolved Hide resolved
tests/test_dev.py Outdated Show resolved Hide resolved
tests/test_dev.py Show resolved Hide resolved
tests/test_dev.py Show resolved Hide resolved
@aramnhammer
fix style
23af5dd 
\n(feature/161_handle_failure_if_branch_not_pushed)
@aramnhammer
rm uneede stuff from test_review_push_fails
631e1d1 
\n(feature/161_handle_failure_if_branch_not_pushed)
@aramnhammer
assert reviewer does not get called on failed push
2b1cc04 
\n(feature/161_handle_failure_if_branch_not_pushed)
@aramnhammer
remove more unneeded things, add checks to ensure things are not called
ddc0b68 
\n(feature/161_handle_failure_if_branch_not_pushed)
@aramnhammer
fix test
51cd086 
\n(feature/161_handle_failure_if_branch_not_pushed)
@aramnhammer
Merge branch 'develop' into feature/161_handle_failure_if_branch_not_…
6682e6e 
…pushed
stopthatcow
stopthatcow reviewed Jun 7, 2020
View reviewed changes
tests/test_dev.py Outdated Show resolved Hide resolved
stopthatcow
stopthatcow reviewed Jun 7, 2020
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@aramnhammer
update comment in gitignore
576296a 
\n(feature/161_handle_failure_if_branch_not_pushed)
@aramnhammer
rm unused import
307863c 
\n(feature/161_handle_failure_if_branch_not_pushed)
@aramnhammer
fix assert to use assert_not_called
5b70c0e 
\n(feature/161_handle_failure_if_branch_not_pushed)
@stopthatcow stopthatcow merged commit c407689 into develop Jun 10, 2020
@stopthatcow stopthatcow deleted the feature/161_handle_failure_if_branch_not_pushed branch June 10, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stopthatcow stopthatcow stopthatcow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github raises an exception if review is not well formed
3 participants
@aramnhammer @coveralls @stopthatcow