Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the v100 handshake to properly check version of server and client #3

Closed
ajanian opened this issue Oct 7, 2020 · 7 comments

Comments

@ajanian
Copy link
Contributor

ajanian commented Oct 7, 2020

Using the reference implementation at https://github.com/maxicus/ib-tws-api port the v100 handshake over. This will make the sending and receiving much safer throughout

@mfrener
Copy link
Contributor

mfrener commented Dec 17, 2020

Is there any plan or timeline for this? Need a cloud of V100 features (such PnL and singlePnL unrealizedPnL / realizedPnL).
Wondering if it is worth waiting, if I shall implement it and do a PR.

@ceddybi
Copy link
Member

ceddybi commented Dec 17, 2020

@mfrener it would be super awesome if you added a PR for it, thank you very much

@mfrener
Copy link
Contributor

mfrener commented Dec 24, 2020

V100 is implemented on ready for testing on https://github.com/stoqey/ib/tree/overhaul/port-ts branch (as well as some more new features, the branch now has a full API 9.76 / May 08 2019 implementation).

I will test it my own app, if you have apps that depend on this lib, pls try them with port-ts branch too to make sure everything still works. You need to change creation of IB object, see example on Welcome page - rest of the interface should be backward compatible, except a couple of functions signatures that where not in sync with official API - they have been change to be same).
PR to master will follow next 2-3 days, after I feel confident enough that nothing has been broken ;)

@ajanian
Copy link
Contributor Author

ajanian commented Dec 24, 2020 via email

@mfrener
Copy link
Contributor

mfrener commented Dec 24, 2020

ok.. so if you use "supporting" objects such as Contract, Oder, Condition objects.. you actually need to change more code in the app. This is are real class objects now, so no more ib.contract.stock('AAPL'), but new Stock("APPL")
But we have an API doc now as well https://stoqey.github.io/ib-doc/ .. good test to see if you can figure how to port your app using it :D

@ceddybi
Copy link
Member

ceddybi commented Dec 28, 2020

@mfrener I think this should be closed?

@mfrener
Copy link
Contributor

mfrener commented Dec 28, 2020

Yes. V100Plus is now enabled by default on master.
(use IBApi.disableUseV100Plus() if you want to fallback to pre-V100 of any reason).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants