Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove broken handlebar util package #25

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix: remove broken handlebar util package #25

merged 1 commit into from
Sep 28, 2023

Conversation

btkostner
Copy link
Contributor

@btkostner btkostner commented Sep 28, 2023

Fun story, handlebars-helpers won't work because someone thought it was a good idea to override the require() function, which breaks ncc. And because it runs inline, it can't be conditionally not loaded. :/

Anyway, I just wrote the one helper I needed inline. We can extend it as needed.

Fixes common-config-elixir runs: https://github.com/stordco/common-config-elixir/actions/runs/6343807016/job/17232517554

@btkostner btkostner requested a review from a team September 28, 2023 21:03
@btkostner btkostner self-assigned this Sep 28, 2023
@btkostner btkostner merged commit 76fee05 into main Sep 28, 2023
4 checks passed
@btkostner btkostner deleted the handlebars branch September 28, 2023 21:04
btkostner pushed a commit that referenced this pull request Sep 28, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.9.1](v1.9.0...v1.9.1)
(2023-09-28)


### Bug Fixes

* remove broken handlebar util package
([#25](#25))
([76fee05](76fee05))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants