Pause prefetches when non-prefetch request is sent to origin #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leotoll
reviewed
Feb 12, 2020
|
Updated per prior comments, and tests added. |
kevhender
force-pushed
the
kh-sw-pause
branch
from
b641e99
to
2f2c0de
Compare
kevhender
force-pushed
the
kh-sw-pause
branch
from
2f2c0de
to
8d73312
Compare
markbrocato
requested changes
Feb 19, 2020
service-worker/bootstrap.js
Outdated
| // until the request finishes, then resumes prefetching | ||
| abortPrefetches() | ||
| event.respondWith( | ||
| fetch(event.request).then(resp => { |
There was a problem hiding this comment.
I think you need to also resume in a cache block here, so that prefetches can be resumed if the last fetch fails.
There was a problem hiding this comment.
Added a catch, and a test for that case.
leotoll
reviewed
Feb 19, 2020
service-worker/bootstrap.js
Outdated
Comment on lines
256
to
262
| resumePrefetches() | ||
| } | ||
| return resp | ||
| }) | ||
| .catch(e => { | ||
| if (toResume.size) { | ||
| resumePrefetches() |
There was a problem hiding this comment.
I guess resumePrefetches can be moved to finally, then there would be no code duplication and no need for catch clause, maybe I am wrong
There was a problem hiding this comment.
In order to do that, we would need to rewrite this using async/await instead of promises, which we should, as I believe those are natively supported in the service worker.
# Conflicts: # package-lock.json # package.json
|
Fixed the merge conflicts, this should be good to go now. |
markbrocato
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.