-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ObjectStore #128
ObjectStore #128
Conversation
Pull Request Test Coverage Report for Build 1585
💛 - Coveralls |
@jtolds After removing the methods for extended attributes, there is not much left in the ObjectStore layer - it just prepends "object" to the path and calls the StreamStore, which also seems redundant in the current situation. If we don't need extended attributes as streams, is there any other reason to have streams in the architecture of the Structured File Storage? If no then I suggest to remove the StreamStore layer and move its responsibilities to the ObjectStore. |
@jtolds As discussed, the ObjectStore for now will just serialize the metadata for the StreamStore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great
// ListItem is a single item in a listing | ||
type ListItem struct { | ||
path paths.Path | ||
meta Meta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably need an IsPrefix bool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will add such method to the Path type, so no need for a flag here.
* master: Config updates (storj#141) don't require a config file (storj#151) ObjectStore (storj#128) Errcheck (storj#133) adds segmentStore Get, List, Delete (storj#143) adding Kiev team to CLA (storj#149) Fix jenkins (storj#139) saves metadata to the pointer in segmentStore Put (storj#142) adds SegmentStore Put functionality (storj#138) Implement miniogw in terms of ObjectStore (storj#117) adds alex and nadine to clabot (storj#136)
* master: Config updates (storj#141) don't require a config file (storj#151) ObjectStore (storj#128) Errcheck (storj#133) adds segmentStore Get, List, Delete (storj#143) adding Kiev team to CLA (storj#149) Fix jenkins (storj#139) saves metadata to the pointer in segmentStore Put (storj#142) adds SegmentStore Put functionality (storj#138) Implement miniogw in terms of ObjectStore (storj#117) adds alex and nadine to clabot (storj#136)
* WIP ObjectStore * Remove methods for extended attributes * List returns metadata too * No real need to prepend "object" in path * Serialize metadata * List retuns []ListItem instead of []Path
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)