ObjectStore #128
Merged
ObjectStore #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1585
💛 - Coveralls |
|
@jtolds After removing the methods for extended attributes, there is not much left in the ObjectStore layer - it just prepends "object" to the path and calls the StreamStore, which also seems redundant in the current situation. If we don't need extended attributes as streams, is there any other reason to have streams in the architecture of the Structured File Storage? If no then I suggest to remove the StreamStore layer and move its responsibilities to the ObjectStore. |
|
@jtolds As discussed, the ObjectStore for now will just serialize the metadata for the StreamStore. |
jtolio
approved these changes
Jul 16, 2018
| // ListItem is a single item in a listing | ||
| type ListItem struct { | ||
| path paths.Path | ||
| meta Meta |
There was a problem hiding this comment.
We will add such method to the Path type, so no need for a flag here.
bryanchriswhite
added a commit
to bryanchriswhite/storj
that referenced
this pull request
Jul 19, 2018
* master: Config updates (storj#141) don't require a config file (storj#151) ObjectStore (storj#128) Errcheck (storj#133) adds segmentStore Get, List, Delete (storj#143) adding Kiev team to CLA (storj#149) Fix jenkins (storj#139) saves metadata to the pointer in segmentStore Put (storj#142) adds SegmentStore Put functionality (storj#138) Implement miniogw in terms of ObjectStore (storj#117) adds alex and nadine to clabot (storj#136)
bryanchriswhite
added a commit
to bryanchriswhite/storj
that referenced
this pull request
Jul 19, 2018
* master: Config updates (storj#141) don't require a config file (storj#151) ObjectStore (storj#128) Errcheck (storj#133) adds segmentStore Get, List, Delete (storj#143) adding Kiev team to CLA (storj#149) Fix jenkins (storj#139) saves metadata to the pointer in segmentStore Put (storj#142) adds SegmentStore Put functionality (storj#138) Implement miniogw in terms of ObjectStore (storj#117) adds alex and nadine to clabot (storj#136)
iglesiasbrandon
pushed a commit
that referenced
this pull request
Dec 7, 2018
* WIP ObjectStore * Remove methods for extended attributes * List returns metadata too * No real need to prepend "object" in path * Serialize metadata * List retuns []ListItem instead of []Path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is