Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jenkins #139

Merged
merged 2 commits into from
Jul 13, 2018
Merged

Fix jenkins #139

merged 2 commits into from
Jul 13, 2018

Conversation

brimstone
Copy link
Contributor

@brimstone brimstone commented Jul 12, 2018 •
edited by jtolio
Loading

  • This PR fixes Jenkins so it starts building Docker images again.
  • It doesn't do everything that Travis does.
  • Next PR is to move the action of running tests into a container in order to control the environment Jenkins uses while running tests.

This change is Reviewable

@cla-bot cla-bot bot added the cla-signed label Jul 12, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1534

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.686%
Totals Coverage Status
Change from base Build 1523: 0.0%
Covered Lines: 2151
Relevant Lines: 3487
💛 - Coveralls

phutchins
phutchins reviewed Jul 13, 2018
View reviewed changes
Copy link
Contributor

@phutchins phutchins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@phutchins phutchins merged commit 544cf46 into master Jul 13, 2018
@brimstone brimstone deleted the fix-jenkins branch July 13, 2018 15:05
bryanchriswhite added a commit to bryanchriswhite/storj that referenced this pull request Jul 19, 2018
@bryanchriswhite
Merge branch 'master' into node-id
0b82ed2 
* master:
  Config updates (storj#141)
  don't require a config file (storj#151)
  ObjectStore (storj#128)
  Errcheck (storj#133)
  adds segmentStore Get, List, Delete (storj#143)
  adding Kiev team to CLA (storj#149)
  Fix jenkins (storj#139)
  saves metadata to the pointer in segmentStore Put (storj#142)
  adds SegmentStore Put functionality (storj#138)
  Implement miniogw in terms of ObjectStore (storj#117)
  adds alex and nadine to clabot (storj#136)
bryanchriswhite added a commit to bryanchriswhite/storj that referenced this pull request Jul 19, 2018
@bryanchriswhite
Merge branch 'master' into node-id
19183ec 
* master:
  Config updates (storj#141)
  don't require a config file (storj#151)
  ObjectStore (storj#128)
  Errcheck (storj#133)
  adds segmentStore Get, List, Delete (storj#143)
  adding Kiev team to CLA (storj#149)
  Fix jenkins (storj#139)
  saves metadata to the pointer in segmentStore Put (storj#142)
  adds SegmentStore Put functionality (storj#138)
  Implement miniogw in terms of ObjectStore (storj#117)
  adds alex and nadine to clabot (storj#136)
iglesiasbrandon pushed a commit that referenced this pull request Dec 7, 2018
@brimstone @phutchins
Fix jenkins (#139)
32543e5 
* Attempt to fix Jenkinsfile

* Only deploy on master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phutchins phutchins phutchins approved these changes

@coyle coyle Awaiting requested review from coyle

@phthano-zz phthano-zz Awaiting requested review from phthano-zz

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brimstone @coveralls @phutchins