Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saves metadata to the pointer in segmentStore Put #142

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

navillasa
Copy link
Contributor

@navillasa navillasa commented Jul 12, 2018

Populates the Metadata field in a pointer with the given metadata (bytes) containing encryption and streaming info.

Later for the segmentStore Get method, the metadata stored in the pointer should get returned in the Get method as part of the Meta struct:

type Meta struct {
	Data []byte
}

This change is Reviewable

@cla-bot cla-bot bot added the cla-signed label Jul 12, 2018
@coveralls
Copy link

coveralls commented Jul 12, 2018

Pull Request Test Coverage Report for Build 1558

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.686%

Totals Coverage Status
Change from base Build 1552: 0.0%
Covered Lines: 2151
Relevant Lines: 3487

💛 - Coveralls

Copy link
Contributor

@dylanlott dylanlott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L 🅱️ T M

@navillasa navillasa merged commit ff4e63b into storj:master Jul 12, 2018
@navillasa navillasa deleted the metadata branch July 12, 2018 23:50
bryanchriswhite added a commit to bryanchriswhite/storj that referenced this pull request Jul 19, 2018
* master:
  Config updates (storj#141)
  don't require a config file (storj#151)
  ObjectStore (storj#128)
  Errcheck (storj#133)
  adds segmentStore Get, List, Delete (storj#143)
  adding Kiev team to CLA (storj#149)
  Fix jenkins (storj#139)
  saves metadata to the pointer in segmentStore Put (storj#142)
  adds SegmentStore Put functionality (storj#138)
  Implement miniogw in terms of ObjectStore (storj#117)
  adds alex and nadine to clabot (storj#136)
bryanchriswhite added a commit to bryanchriswhite/storj that referenced this pull request Jul 19, 2018
* master:
  Config updates (storj#141)
  don't require a config file (storj#151)
  ObjectStore (storj#128)
  Errcheck (storj#133)
  adds segmentStore Get, List, Delete (storj#143)
  adding Kiev team to CLA (storj#149)
  Fix jenkins (storj#139)
  saves metadata to the pointer in segmentStore Put (storj#142)
  adds SegmentStore Put functionality (storj#138)
  Implement miniogw in terms of ObjectStore (storj#117)
  adds alex and nadine to clabot (storj#136)
iglesiasbrandon pushed a commit that referenced this pull request Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants