web/satellite: token payments logic #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
JessicaGreben and
kaloyan-raev
and removed request for
a team
NikolaiYurchenko
requested review from
crawter,
VitaliiShpital,
Qweder93 and
rikysya
and removed request for
JessicaGreben and
kaloyan-raev
web/satellite/src/components/account/billing/depositAndBilling/Countdown.vue
Outdated
Show resolved
Hide resolved
web/satellite/src/components/account/billing/paymentMethods/PaymentMethods.vue
Outdated
Show resolved
Hide resolved
web/satellite/src/components/account/billing/depositAndBilling/BillingItem.vue
Outdated
Show resolved
Hide resolved
crawter
reviewed
Nov 18, 2019
| throw new ErrorUnauthorized(); | ||
| } | ||
|
|
||
| throw new Error('can not process coin payment'); |
There was a problem hiding this comment.
api response could contain 3 error codes:
401 - unauthrized
400 - bad data
500 - internal error
we could possibly add new error check to improve err message
crawter
reviewed
Nov 18, 2019
web/satellite/src/api/payments.ts
Outdated
| throw new Error('can not process coin payment'); | ||
| } | ||
|
|
||
| return await response.json(); |
There was a problem hiding this comment.
lets return real type, not a deserialized json
crawter
reviewed
Nov 18, 2019
| private readonly type: BillingHistoryItemType; | ||
|
|
||
| private readonly expirationDateTime: number; | ||
| private now = Math.trunc((new Date()).getTime() / 1000); |
There was a problem hiding this comment.
why do we need additional brackets around new Date?
crawter
reviewed
Nov 18, 2019
| @Prop({default: 0}) | ||
| private readonly type: BillingHistoryItemType; | ||
|
|
||
| private readonly expirationDateTime: number; |
There was a problem hiding this comment.
this should be renamed. Timeout, f.e.
crawter
reviewed
Nov 18, 2019
web/satellite/src/types/payments.ts
Outdated
| if (this.type) { | ||
| return this.start.toLocaleDateString(); | ||
| public get quantity(): Amount { | ||
| if (this.tokenAmount === '') { |
crawter
reviewed
Nov 20, 2019
crawter
reviewed
Nov 20, 2019
| }, | ||
| }) | ||
| export default class BillingItem extends Vue { | ||
| @Prop({default: new BillingHistoryItem()}) |
There was a problem hiding this comment.
() => new BillingHistoryItem()
crawter
reviewed
Nov 20, 2019
| import { BillingHistoryItemType } from '@/types/payments'; | ||
|
|
||
| @Component | ||
| export default class BillingHistoryDate extends Vue { |
|
|
||
| private readonly expirationTimeInSeconds: number; | ||
| private nowInSeconds = Math.trunc(new Date().getTime() / 1000); | ||
| private intervalID; |
web/satellite/src/main.ts
Outdated
|
|
||
| Vue.filter('twoDigits', function (value: number): string { | ||
| if (value.toString().length <= 1) { | ||
| return `0${value.toString()}`; |
There was a problem hiding this comment.
.toString() is redundant here
NikolaiYurchenko
added
Do Not Merge
and removed
Reviewer Can Merge
NikolaiYurchenko
added
Reviewer Can Merge
crawter
reviewed
Nov 22, 2019
| import { BillingHistoryItemType } from '@/types/payments'; | ||
|
|
||
| @Component | ||
| export default class BillingHistoryDate extends Vue { |
There was a problem hiding this comment.
it would be nice to have more comments here
| @@ -123,6 +127,10 @@ export default class PaymentMethods extends Vue { | |||
| return this.areaState === PaymentMethodsBlockState.ADDING_CARD; | |||
| } | |||
|
|
|||
| public onChangeTokenValue(value: number) { | |||
|
|
||
| return; | ||
| } | ||
|
|
||
| public onConfirmAddSTORJ(): void { | ||
| public async onConfirmAddSTORJ(): Promise<void> { | ||
| if (this.tokenDepositValue >= 1000000 || this.tokenDepositValue === 0) { |
There was a problem hiding this comment.
lets place it to constants?
| @@ -123,6 +140,18 @@ export enum BillingHistoryItemType { | |||
| Transaction = 1, | |||
| } | |||
|
|
|||
| export class TokenDeposit { | |||
crawter
approved these changes
Nov 22, 2019
VitaliiShpital
approved these changes
Nov 22, 2019
bryanchriswhite
added a commit
that referenced
this pull request
Nov 25, 2019
* storj/master: (63 commits) web/satellite: token payments logic (#3581) satellite/metainfo: reduce pointerDB access for CommitObject (#3589) satellite/metainfo: Fix misspelling in comment (#3636) argon2: choose a steady parallelism value (#3630) satellitedb: add support to testplanet for cockroachdb (#3634) satellite/console/auth: return in error handle added (#3639) Make sed a little more cross platformable (#3629) web: ms edge support bug fixed (#3638) web/satellite: registration/welcome message fixed, usage-report url fixed, storj-sim fixed (#3622) web/satellite: fonts changed to Inter (#3620) storagenode/updater: read identity location from storagenode's config.yaml (#3607) cmd/segment-reaper: Implement bitmask type (#3626) storagenode/gracefulexit: improve logging (#3633) private/testplanet: add a mock referral manager server into testplanet (#3631) satellite/gracefulexit: refactor concurrency (#3624) pkg/pb/referralmanager: update to add satellite ID to Get Tokens request (#3625) satellite/metainfo: improve Loop comments (#3595) storagenode: add bandwidth metrics (#3623) satellite/console: Add security headers (#3615) satellite/payments: token deposit accept cents (#3628) ...
bryanchriswhite
pushed a commit
to bryanchriswhite/storj
that referenced
this pull request
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
front end logic and markup for token payment related components
Why:
to be able to create token transactions
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)