Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storagenode/gracefulexit: improve logging #3633

Merged
merged 2 commits into from
Nov 22, 2019
Merged

storagenode/gracefulexit: improve logging #3633

merged 2 commits into from
Nov 22, 2019

Conversation

littleskunk
Copy link
Member

@littleskunk littleskunk commented Nov 22, 2019 •
edited by stefanbenten

What: Improve logging.

Why: The graceful exit node was transfering a lot of pieces but didn't print out any log messages.

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@littleskunk littleskunk requested a review from a team November 22, 2019 01:30
@cla-bot cla-bot bot added the cla-signed label Nov 22, 2019
@ghost ghost requested review from kaloyan-raev and wthorp and removed request for a team November 22, 2019 01:30
@littleskunk littleskunk added Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR labels Nov 22, 2019
stefanbenten
stefanbenten previously approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@stefanbenten stefanbenten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

VinozzZ
VinozzZ previously approved these changes Nov 22, 2019
View reviewed changes
@stefanbenten stefanbenten merged commit 8842b0c into master Nov 22, 2019
@stefanbenten stefanbenten deleted the jh/gracefulexit branch November 22, 2019 02:10
bryanchriswhite added a commit that referenced this pull request Nov 25, 2019
@bryanchriswhite
Merge remote-tracking branch 'storj/master' into bryan/installer-testing
2263a15 
* storj/master: (63 commits)
  web/satellite:  token payments logic (#3581)
  satellite/metainfo: reduce pointerDB access for CommitObject (#3589)
  satellite/metainfo: Fix misspelling in comment (#3636)
  argon2: choose a steady parallelism value (#3630)
  satellitedb: add support to testplanet for cockroachdb (#3634)
  satellite/console/auth: return in error handle added (#3639)
  Make sed a little more cross platformable (#3629)
  web: ms edge support bug fixed (#3638)
  web/satellite: registration/welcome message fixed, usage-report url fixed, storj-sim fixed (#3622)
  web/satellite: fonts changed to Inter (#3620)
  storagenode/updater: read identity location from storagenode's config.yaml (#3607)
  cmd/segment-reaper: Implement bitmask type (#3626)
  storagenode/gracefulexit: improve logging (#3633)
  private/testplanet: add a mock referral manager server into testplanet (#3631)
  satellite/gracefulexit: refactor concurrency (#3624)
  pkg/pb/referralmanager: update to add satellite ID to Get Tokens request (#3625)
  satellite/metainfo: improve Loop comments (#3595)
  storagenode: add bandwidth metrics (#3623)
  satellite/console: Add security headers (#3615)
  satellite/payments: token deposit accept cents (#3628)
  ...
bryanchriswhite pushed a commit to bryanchriswhite/storj that referenced this pull request Oct 29, 2020
@littleskunk @bryanchriswhite
storagenode/gracefulexit: improve logging (storj#3633)
7484146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanbenten stefanbenten stefanbenten approved these changes

@VinozzZ VinozzZ VinozzZ approved these changes

@kaloyan-raev kaloyan-raev Awaiting requested review from kaloyan-raev

@wthorp wthorp Awaiting requested review from wthorp

Assignees
No one assigned
Labels
cla-signed Request Code Review Code review requested Reviewer Can Merge If all checks have passed, non-owner can merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@littleskunk @stefanbenten @VinozzZ