cmd/segment-reaper: Implement bitmask type #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a bitmask type for implementing its logic to detect if an index is set or not.
ifraixedes
added
Request Code Review
ghost
requested review from
isaachess and
zeebo
and removed request for
a team
|
|
||
| // Count returns the number of tracked indexes. | ||
| func (mask *bitmask) Count() int { | ||
| return bits.OnesCount64(uint64(*mask)) |
There was a problem hiding this comment.
Fantastic! I didn't know there is a built-in library with efficient algorithms for this kind of operations.
kaloyan-raev
approved these changes
Nov 22, 2019
mniewrzal
approved these changes
Nov 22, 2019
Currently, the I'd prefer to move it when we have the need of using the type in other packages considering that refactoring tasks won't be that much. |
bryanchriswhite
added a commit
that referenced
this pull request
Nov 25, 2019
* storj/master: (63 commits) web/satellite: token payments logic (#3581) satellite/metainfo: reduce pointerDB access for CommitObject (#3589) satellite/metainfo: Fix misspelling in comment (#3636) argon2: choose a steady parallelism value (#3630) satellitedb: add support to testplanet for cockroachdb (#3634) satellite/console/auth: return in error handle added (#3639) Make sed a little more cross platformable (#3629) web: ms edge support bug fixed (#3638) web/satellite: registration/welcome message fixed, usage-report url fixed, storj-sim fixed (#3622) web/satellite: fonts changed to Inter (#3620) storagenode/updater: read identity location from storagenode's config.yaml (#3607) cmd/segment-reaper: Implement bitmask type (#3626) storagenode/gracefulexit: improve logging (#3633) private/testplanet: add a mock referral manager server into testplanet (#3631) satellite/gracefulexit: refactor concurrency (#3624) pkg/pb/referralmanager: update to add satellite ID to Get Tokens request (#3625) satellite/metainfo: improve Loop comments (#3595) storagenode: add bandwidth metrics (#3623) satellite/console: Add security headers (#3615) satellite/payments: token deposit accept cents (#3628) ...
bryanchriswhite
pushed a commit
to bryanchriswhite/storj
that referenced
this pull request
Oct 29, 2020
Define a bitmask type for implementing its logic to detect if an index is set or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Define a bitmask type.
Why: Because we want to encapsulate the logic around the bitmask segment index tracking.
Ticket: https://storjlabs.atlassian.net/browse/V3-3235
Please describe the tests: Created tests for the methods of the new type.
Please describe the performance impact: N/A
Code Review Checklist (to be filled out by reviewer)