Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stream bifurcation #339

Open
pesekon2 opened this issue Feb 24, 2024 · 2 comments
Open

Support stream bifurcation #339

pesekon2 opened this issue Feb 24, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@pesekon2
Copy link
Collaborator

pesekon2 commented Feb 24, 2024

The code currently ends up in an error when there are three linestrings connected to one node in streams (error is raised by this part of the code). SMODERP2D should support this. Another problem is that the error does not occur when one linestring is connected to another one in the middle instead of at the very end (although there are also three linestrings coming out of a node then) so the behaviour is very different for the two very similar cases.

@kavkapet: Is there any recommended approach on how to solve it?

Streams that would cause this error in our rain simulator test data are attached: streams.zip

@pesekon2 pesekon2 added bug Something isn't working enhancement New feature or request labels Feb 24, 2024
pesekon2 added a commit that referenced this issue Mar 1, 2024
only multiple outflows from one stream is considered bifurcation, multiple inflows are fine

see #339
pesekon2 added a commit that referenced this issue Mar 2, 2024
only multiple outflows from one stream is considered bifurcation, multiple inflows are fine

see #339
@pesekon2
Copy link
Collaborator Author

pesekon2 commented Mar 2, 2024

The bug with three streams coming from one point was solved in #341. The problem with a line connected to the middle of another line (the point knows only about the connecting line) still stays. Also, real bifurcation (except those middle-line ones) are still not supported.

@pesekon2
Copy link
Collaborator Author

pesekon2 commented Mar 7, 2024

The problem with a line connected to the middle of another line solved in 71f1933. The only missing thing is to support real bifurcation.

@pesekon2 pesekon2 removed the bug Something isn't working label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants