Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issue with loading apiKey.properties from homepath #27

Merged
merged 1 commit into from
Feb 3, 2016

Conversation

typerandom
Copy link
Contributor

Fixes a issue where an API key wouldn't be loaded correctly from a home path.

How to verify

  1. Checkout this branch.
  2. Execute $ npm link to make it available as a link.
  3. Create an empty test project folder (e.g. stormpath-config-test) and $ cd into it.
  4. Execute $ npm init --yes.
  5. Execute $ npm link stormpath-config so that we link to our stormpath-config master branch.
  6. Create a new file called app.js and put the contents of this gist in it.
  7. Create an apiKey.properties with the following content and put it in the ~/.stormpath/ directory.
  8. Run $ node app.js.

Expected

Console outputs:

null { bob: 123, client: { apiKey: { id: 'abc', secret: 'def' } } }

Fixes #28.

@robertjd
Copy link
Member

Verified that the problem has been fixed, merge!

@timothyej
Copy link
Contributor

👍 @typerandom are you working on this (it has the label in progress)?

timothyej pushed a commit that referenced this pull request Feb 3, 2016
Fix: Issue with loading apiKey.properties from homepath
@timothyej timothyej merged commit c7945a5 into master Feb 3, 2016
@timothyej timothyej deleted the fix-load-api-key-homepath-issue branch February 3, 2016 12:20
@typerandom
Copy link
Contributor Author

Strange, it's place in review in waffle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants