Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable persistent uefi state support#170 #13

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

DanielFroehlich
Copy link
Contributor

No description provided.

@DanielFroehlich DanielFroehlich requested a review from rbo May 23, 2024 08:18
@rbo
Copy link
Member

rbo commented May 23, 2024

Does it mean every VM need an extra 12 MB storage to persist uefi? Or is this configure at vm level as well?

@DanielFroehlich
Copy link
Contributor Author

Does it mean every VM need an extra 12 MB storage to persist uefi? Or is this configure at vm level as well?

This PR here is just the base config for the cluster. It has to be enable at the vm level to be in effect (and create that state PVC). You do that in the VM domain spec like this:

        firmware:
          bootloader:
            efi:
              persistent: true

Which btw currently breaks cloneing - you cant clone a VM with persistet state.

@DanielFroehlich
Copy link
Contributor Author

this now also add observability to ACM support#135

@rbo
Copy link
Member

rbo commented Jun 10, 2024

LGMT

@DanielFroehlich DanielFroehlich merged commit eea9df7 into stormshift:main Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants