-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract markdown importer for novels and screenplays #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimkanovikov
requested changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
проверил, с многострочными комментариями тоже работает?
src/corelib/business_layer/import/screenplay/screenplay_fountain_importer.cpp
Outdated
Show resolved
Hide resolved
src/corelib/business_layer/import/screenplay/screenplay_fountain_importer.cpp
Outdated
Show resolved
Hide resolved
src/corelib/business_layer/import/screenplay/screenplay_fountain_importer.h
Outdated
Show resolved
Hide resolved
iljukhaput
force-pushed
the
abstract_import
branch
from
May 30, 2024 09:31
eb375d5
to
72c9a6f
Compare
dimkanovikov
reviewed
Jun 3, 2024
src/corelib/business_layer/import/abstract_markdown_importer.cpp
Outdated
Show resolved
Hide resolved
src/corelib/business_layer/import/screenplay/screenplay_fountain_importer.cpp
Outdated
Show resolved
Hide resolved
dimkanovikov
requested changes
Jun 3, 2024
src/corelib/business_layer/import/screenplay/screenplay_fountain_importer.cpp
Outdated
Show resolved
Hide resolved
iljukhaput
force-pushed
the
abstract_import
branch
from
June 5, 2024 18:18
72c9a6f
to
9202b8b
Compare
dimkanovikov
requested changes
Jun 7, 2024
src/corelib/business_layer/import/abstract_markdown_importer.cpp
Outdated
Show resolved
Hide resolved
src/corelib/business_layer/import/abstract_markdown_importer.cpp
Outdated
Show resolved
Hide resolved
src/corelib/business_layer/import/abstract_markdown_importer.cpp
Outdated
Show resolved
Hide resolved
src/corelib/business_layer/import/abstract_markdown_importer.cpp
Outdated
Show resolved
Hide resolved
iljukhaput
force-pushed
the
abstract_import
branch
2 times, most recently
from
June 7, 2024 03:51
fb11e32
to
84d22d3
Compare
С многострочными комментариями работает - проверил |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.