-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sandbox): remove container references #366
refactor(sandbox): remove container references #366
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
64d8961
to
be79526
Compare
be79526
to
041d57b
Compare
041d57b
to
593bd75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @demetriusfeijoo. Looking good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
I think, by this PR, it is clearer on the terms. Now that this plugin-sandbox.storyblok.com
app will be called Sandbox all over the code, but now we can redefine the term "container".
, which means..
Container is a component that includes a field plugin within an iframe.
- FieldTypeCustom (storyfront) is a container
- We also have a container in the
@storyblok/field-plugin/test
package - We have a container inside this
sandbox
package.
So in this context, there is a container running within the sandbox environment (as opposed to the production, storyfront environment).
Then it'll be clearer and easier to extract the container part as a common code in the near future.
Thanks for your reviews 💯 and I agree with the definition you brought, @eunjae-lee. 🙌 We could have a It could be used for the Visual Editor, Plugin Editor, Sandbox, |
yeah I guess it would look something like |
…replace-some-occurrences-of-container-with-sandbox # Conflicts: # packages/sandbox/src/components/TranslatableCheckbox.tsx # yarn.lock
What?
packages/container
topackages/sandbox
container
tosandbox
package.json
to consider the new project's namecontainer
withsandbox
in theCONTRIBUTING.md
fileWhy?
JIRA: EXT-1470
The term
container
is too open, and not widely adopted by us when referring to the Sandbox. Replacing it will drive us to have a "ubiquitous language" which will also lead to a better DX.PS: The Vercel action is not running yet since it wasn't modified to consider the new path (
packages/sandbox
) and also the new project name in its settings.PS2: The Sandbox can run locally, but it isn't loading any plugin due to this issue. So, I advise you to check into this branch and perform the tests there since this one is on top of this.