fix: do not optimise module code #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one Daniel, this looks to work for me in my own testing (directly via Node modules). Hopefully it can get through soon as it breaks latest Nuxt. |
|
Thank you, @danielroe, as always, for giving us a hand! 💜 |
|
🎉 This PR is included in version 5.7.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nuxt/nuxt#24387
resolves #660
When vite optimises code, it will crawl that code in a runtime context. But Nuxt modules are always meant to be run in a module context. By removing this we speed up the start of Nuxt for users using storyblok, and also avoid errors caused by trying to resolve Nuxt module imports outside of a Node context.