Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Storybook 8 #232

Merged
merged 15 commits into from
Mar 14, 2024
Merged

Upgrade to Storybook 8 #232

merged 15 commits into from
Mar 14, 2024

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Mar 13, 2024

Closes #231, #229

This PR does a lot of things:

  1. Upgrade bundling strategy to use tsup similar to how it's done in addon-kit
  2. Upgrade all internal Storybooks to SB 8
  3. Combine examples and examples-tab Storybooks into a single Storybook, while still maintaining their separation of / for examples and /tab/ for tab examples
  4. Upgrade almost all dependencies throughout the repository
  5. Formatted the project according to the existing configuration

Todo

  • Fix the link in docs between panel examples and tab examples
  • Fix the table in the docs
📦 Published PR as canary version: 8.0.0--canary.232.a463deb.0

✨ Test out this PR locally via:

npm install @storybook/addon-designs@8.0.0--canary.232.a463deb.0
# or 
yarn add @storybook/addon-designs@8.0.0--canary.232.a463deb.0

- rename "register" directory to "manager"
- remove root *.js entries for compiled entries to dist instead, like src/register-panel.ts
- set correct export maps for exported entries
- upgrade packages
- set optional peer dependencies needed when using the blocks from this package
@JReinhold JReinhold linked an issue Mar 13, 2024 that may be closed by this pull request
5 tasks
@JReinhold JReinhold marked this pull request as draft March 13, 2024 13:00
@JReinhold JReinhold mentioned this pull request Mar 13, 2024
5 tasks
@JReinhold JReinhold marked this pull request as ready for review March 13, 2024 22:17
@JReinhold JReinhold self-assigned this Mar 13, 2024
@JReinhold JReinhold added major Increment the major version when merged dependencies Update one or more dependencies version labels Mar 13, 2024
Comment on lines 63 to 69
"peerDependencies": {
"@storybook/addon-docs": "^8.0.0-alpha.10 || ^8.0.0",
"@storybook/components": "^8.0.0-alpha.10 || ^8.0.0",
"@storybook/manager-api": "^8.0.0-alpha.10 || ^8.0.0",
"@storybook/preview-api": "^8.0.0-alpha.10 || ^8.0.0",
"@storybook/theming": "^8.0.0-alpha.10 || ^8.0.0",
"react": "^16.8.0 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0"
"@storybook/blocks": "^8.0.0",
"@storybook/components": "^8.0.0",
"@storybook/theming": "^8.0.0",
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are only needed by users if they intend to use the doc blocks this package provides.

@valentinpalkovic
Copy link
Contributor

valentinpalkovic commented Mar 14, 2024

@JReinhold: Out of the 13 reported issues, how many would you consider helpful and valuable? And a second question: I think, most errors might not have been reported if TypeScript had been set up stricter (strict mode, for example). Is that the case?

@JReinhold
Copy link
Contributor Author

@valentinpalkovic quickly looking through them, they would all have been caught by a stricter TypeScript mode, so I don't find this specific scenario useful, except for anything else than "you should make your TS config more strict".

@bodograumann
Copy link

I have tried 8.0.0--canary.232.785af00.0 and it works fine afaics. ❤️

Copy link

@JonathanKolnik JonathanKolnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@JReinhold JReinhold merged commit 6c1c7a6 into master Mar 14, 2024
2 of 3 checks passed
@JReinhold JReinhold deleted the 231-storybook-8-upgrade branch March 14, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version major Increment the major version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook 8 upgrade
4 participants