[FEAT] Support Developer Options #87
Conversation
…nable/disable firebase analytics debug view [FEAT] Add toasts support
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @storybook/core-events@7.6.7, @storybook/react@7.6.7 |
|
Hi @amalik2 Need your help to review these PRs , The PRs are using multiple feature branches but all rebased form each other ,
if you like all the features to be merged in one shot then #87 ( hey @chriskurzeja these might be useful, |
packages/devices/src/getDevices.ts
Outdated
| @@ -60,6 +60,64 @@ export const getDefaultOsVersion = (platform: Platform): string => { | |||
| throw new Error(`No osVersion for platform: ${platform}`); | |||
| }; | |||
|
|
|||
| export const getFonts = (platform: Platform): Font[] => { | |||
There was a problem hiding this comment.
Can getFonts and getLocations be moved to separate files? It would be good to separate the location JSON data into individual files as well since there's so much data
ex:
getFonts.ts should contain all font related logic,
getLocations.ts should contain all location related logic, locations.json should contain location data
packages/types/src/index.ts
Outdated
| duration?: number; | ||
| } | ||
|
|
||
| // interface Gesture { |
There was a problem hiding this comment.
Could you remove this since its not used?
|
|
||
| const preview = { | ||
| globalTypes: { | ||
| // location: { |
There was a problem hiding this comment.
Can you include a note indicating that this is just an example of using google maps and that's why its commented out?
| @@ -11,6 +11,7 @@ | |||
| ], | |||
| "scripts": { | |||
| "start": "yarn build:stories && storybook dev -p 53743", | |||
| "start:local": "STORYBOOK_NATIVE_LOCAL_EMULATOR=true yarn build:stories && STORYBOOK_NATIVE_LOCAL_EMULATOR=true storybook dev -p 53743", | |||
There was a problem hiding this comment.
STORYBOOK_NATIVE_LOCAL_EMULATOR=true only needs to be specified once -
this command should be
export STORYBOOK_NATIVE_LOCAL_EMULATOR=true && yarn build:stories && storybook dev -p 53743
| @@ -77,6 +77,7 @@ const promises = components.map(async (component) => { | |||
| return generateStories({ | |||
| category: pascalCase(component.name), | |||
| filePath: `./stories/${component.name}.stories.jsx`, | |||
| // applicationId: "com.example.app", | |||
There was a problem hiding this comment.
Same as above, can you provide a note about why this is commented out?
| api.getChannel()?.emit( | ||
| ACTION_EVENT_NAME, | ||
| EmulatorActions.showLayoutBounds, | ||
| null, // location |
There was a problem hiding this comment.
Can you remove the // location comments in this file?
There was a problem hiding this comment.
emit accepts ordered arguments , the comments indicates the argument type and position
|
@amalik2 pushed requested changes |
|
🚀 PR was released in |
Changes
UI Changes
📦 Published PR as canary version:
3.0.1-canary.87.934.0✨ Test out this PR locally via:
npm install @storybook/native-android-material-deep-link-example@3.0.1-canary.87.934.0 npm install @storybook/native-controls-example@3.0.1-canary.87.934.0 npm install @storybook/native-cross-platform-example@3.0.1-canary.87.934.0 npm install @storybook/native-flutter-example@3.0.1-canary.87.934.0 npm install @storybook/native-ios-example-deep-link@3.0.1-canary.87.934.0 npm install @storybook/native-addon@3.0.1-canary.87.934.0 npm install @storybook/native-controllers@3.0.1-canary.87.934.0 npm install @storybook/deep-link-logger@3.0.1-canary.87.934.0 npm install @storybook/native-dev-middleware@3.0.1-canary.87.934.0 npm install @storybook/native-devices@3.0.1-canary.87.934.0 npm install @storybook/native-components@3.0.1-canary.87.934.0 npm install @storybook/native@3.0.1-canary.87.934.0 npm install @storybook/native-types@3.0.1-canary.87.934.0 # or yarn add @storybook/native-android-material-deep-link-example@3.0.1-canary.87.934.0 yarn add @storybook/native-controls-example@3.0.1-canary.87.934.0 yarn add @storybook/native-cross-platform-example@3.0.1-canary.87.934.0 yarn add @storybook/native-flutter-example@3.0.1-canary.87.934.0 yarn add @storybook/native-ios-example-deep-link@3.0.1-canary.87.934.0 yarn add @storybook/native-addon@3.0.1-canary.87.934.0 yarn add @storybook/native-controllers@3.0.1-canary.87.934.0 yarn add @storybook/deep-link-logger@3.0.1-canary.87.934.0 yarn add @storybook/native-dev-middleware@3.0.1-canary.87.934.0 yarn add @storybook/native-devices@3.0.1-canary.87.934.0 yarn add @storybook/native-components@3.0.1-canary.87.934.0 yarn add @storybook/native@3.0.1-canary.87.934.0 yarn add @storybook/native-types@3.0.1-canary.87.934.0