-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook does not work with Expo #32
Comments
Update: I went through the guide on the site again and the best I am able to do is get storybook running in the browser. However it is not picking up any of the stories. As for my app, since I replaced the app entry point with |
Ok, so, I haven't tried installing it in an expo init'd project, but using crna I got it to work by doing the following:
Now, using npm run storybook does not load stories, but at least it seems to work on my mobile device. This whole thing is really frustrating. |
First part of this issue is duplicate to storybookjs/storybook#5893 Second part may need some investigation cc @benoitdion |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Non-ideal quick fix: when installing storybook, choose v4.1.18.
(Also at some point during the Storybook install you have to choose your output. I selected REACT_NATIVE) |
@kristremblay please take a look at the migration instruction for 5.1: https://github.com/storybooks/storybook/blob/next/MIGRATION.md#react-native-server |
@kristremblay In case you didn't have time to finalize yet, I put together a finished repo as a reference. Great catch on the appKey btw. The "don't need to do this if you're using expo" threw me as well. Glad you caught it. react-native-expo-storybook-v5 @shilman I noticed that I was running into compilation issues with |
Thanks @alechp . What issues were you having? I know there were some addon-related issues in RN 5.1 but I'm not sure if they're documented or tracked, so if you let me know it would help us with the release. Also, are you on the latest alpha? 🙏 |
I received this compile time error:
Here's the package: In terms of https://www.npmjs.com/package/@storybook/cli I chose whatever the latest version listed was... I recall it was a UPDATE (11:19AM PST): Confirmed that the version I installed from was Notice that you tagged my previous repo comment to the 5.1.0 milestone. Should it be tagged to 5.2.0 instead? |
@shilman Update: Here's the original error (returns when I add You can recreate this by
|
@alechp Please use the latest 5.1.0 version. The 5.2.0 version may be messed up -- it's a long story. |
@shilman got alpha 40 running. Current errors being thrown: In Expo
Added context
UPDATE:
I can keep adding missing modules, but obviously this isn't right. UPDATE 2: UPDATE 3: |
@shilman Not sure if this is a bug of alpha40 or supposed to be a feature of Storybook: Whenever I run eg. I installed the Storysource addon (https://github.com/storybooks/storybook/tree/master/addons/storysource) via and was prompted to choose the install version again: It also seems to re-run if I run |
@alechp Not sure what's going on there. @benoitdion have you seen this? |
I haven't seen this. What does your |
@benoitdion |
@benoitdion @shilman Update: Also getting prompted to select Storybook version on |
Consider using expo 33 with |
@alechp `"scripts": { "devDependencies": { I used your workaround and got it to work on the android emulator from Android SDK and there the stories are shown but not on Web. I also get into this loop where I need to select the version every time I run yarn. I installed alpha 40. So far the states I have achieved are either infinite loading or no stories on the web. |
@alechp @TheWeeezel did you try syncing all storybook related deps to the same version? |
Sorry for my late answer. Yes i did. I figured i wait for Expo 33 to release. I tried so many versions but gave up. |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
@TheWeeezel I'm having similar issues My hunch is that this has to do with the Android emu and not Storybook (or Expo). Admittedly getting this working on Android isn't top priority for me rn. Have you had any luck getting passed this on your end? |
@Gongreg I agree re: issue being too big. More generic support thread than actual issue at this point. Worth closing IMO |
Closing this issue. If you have any issues feel free to open a separate issue! @alechp if you could notify here does the adb reverse command solve your issue. |
Any news about this issue ? With expo 34 and Storybook 5 Story are loading forever on the left panel. |
in my case the think is that main file is different with expo and story book. The left loading panel forever is because by default story book loads a part of de index.js in --web but the folders with examples of stories are only --ios and --android. So is tricky but you can make a "switch" and define what loader wants. Example: I made a switch navigator in my app. `import React from 'react'; const StoryBookLoader = ({ }) => So when i want to work with StoryBook, i follow these steps: Hope worth for someone :) |
Having the same issue! |
@igorgidea |
This happened to me, turned out to be a configuration issue. Following this helped me get it setup: |
Describe the bug
When trying to install Storybook with the most recent release of Expo, the process fails at
installing dependencies
with the errorNo matching version found for @storybook/react-native@^5.0.6
.To Reproduce
Steps to reproduce the behavior:
expo init ProjectName
getstorybook
Expected behavior
Storybook would install properly and I would be a happy boy.
System:
Log dump
The text was updated successfully, but these errors were encountered: