Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate addon-links and addon-actions as "built-in addons" #1017

Closed
6 tasks done
shilman opened this issue May 11, 2017 · 2 comments
Closed
6 tasks done

Deprecate addon-links and addon-actions as "built-in addons" #1017

shilman opened this issue May 11, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@shilman
Copy link
Member

shilman commented May 11, 2017

why

Built-in addons are confusing and are only there for backwards compatibility. For example, they generate confusion like this #1016, and multiple cases in the documentation etc.

Currently there are three types of addons:

  • "built-in addons" (actions, links)
  • "core addons" that are part of the storybooks monorepo but are not included by default (notes, info, etc.)
  • "community addons" which are maintained in separate repos by community members

what

I propose we:

  • remove actions and links as built-in
  • update the docs
  • make the actions/links addons like normal "core addons"
  • add migration instructions

Alternatively:

Old-style code will break, but since we are doing a major version bump that's to be expected and we can add it to the migration guide.

@ndelangen
Copy link
Member

I think removing them in 3.0.0 is do-able tbh.

@arunoda
Copy link
Member

arunoda commented May 16, 2017

Okay. This looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants