Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls: Add debounce logic #11427

Closed
shilman opened this issue Jul 6, 2020 · 1 comment
Closed

Controls: Add debounce logic #11427

shilman opened this issue Jul 6, 2020 · 1 comment

Comments

@shilman
Copy link
Member

shilman commented Jul 6, 2020

Controls are not currently debounced, leading to typing jankiness for the user.

Proposal:

  • Rather than debouncing, send all input events to the story store
  • Keep local state in the control so that input can update in real time
  • Only update a control from the story store if the control not focused, resolve differences on blur

This is a follow-up to #10701 , which proposes a simple debounce

@shilman
Copy link
Member Author

shilman commented Jul 6, 2020

Whoopee!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-beta.44 containing PR #11430 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant