-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: Support <StrictMode />
and <Suspense />
in source viewer
#19785
Merged
ndelangen
merged 12 commits into
storybookjs:next
from
zhyd1997:refactor/ea45781-yadong-jsx-decorator
Dec 14, 2023
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a275999
refactor: inherited 'react-element-to-jsx-string'.
zhyd1997 543bdf4
fix: passed undefined value into displayNameDefaults if getDocgenSect…
zhyd1997 3d25687
fix: used reassigned renderedJSX instead of code var.
zhyd1997 9d96efb
test: log renderedJSX for debug.
zhyd1997 20863a7
Merge branch 'storybookjs:next' into refactor/ea45781-yadong-jsx-deco…
zhyd1997 7797cda
fix: Cannot read properties of undefined (reading '__docgenInfo').
zhyd1997 ef1d14a
feat: added StrictMode support in source code snippet.
zhyd1997 946ab3f
Merge branch 'storybookjs:next' into refactor/ea45781-yadong-jsx-deco…
zhyd1997 1893bc1
Merge branch 'storybookjs:next' into refactor/ea45781-yadong-jsx-deco…
zhyd1997 4fbcd93
fix: added missing arguments.
zhyd1997 bd5bdb7
Merge branch 'next' into refactor/ea45781-yadong-jsx-decorator
ndelangen bd40b6e
Merge branch 'release-8-0' into refactor/ea45781-yadong-jsx-decorator
ndelangen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major Change:
displayNameDefaults.displayName
should beundefined
ifgetDocgenSection
returnsnull
:storybook/code/lib/docs-tools/src/argTypes/docgen/utils/docgenInfo.ts
Lines 14 to 16 in 9a07fcb
and then the logic will be handled by
react-element-to-jsx-string
:https://github.com/algolia/react-element-to-jsx-string/blob/984f26908c17cea134fa53d17ac51f179e5195b2/src/parser/parseReactElement.js#L47-L77
We don't need to rewrite redundant code here.