Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Essentials: Export interface PresetOptions #21195

Merged

Conversation

tyankatsu0105
Copy link
Contributor

@tyankatsu0105 tyankatsu0105 commented Feb 22, 2023

Closes #

What I did

I export PresetOptions at addon/essentials.
This PR makes us allow to use type definition with JSDoc:

const config = {
  addons: [
    {
      name: "@storybook/addon-essentials",
      /**
       * @type {import('@storybook/addon-essentials').PresetOptions}
       */
      options: {
        ...
      }
    }
  ]
};

スクリーンショット 2023-02-22 9 53 52

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen
Copy link
Contributor

Thanks looks great! we have a feature freeze until the 7 release, and will get this in after that

@kasperpeulen kasperpeulen self-requested a review July 28, 2023 09:11
@kasperpeulen
Copy link
Contributor

Could you resolve the conflicts @tyankatsu0105? Then we will get it in!

@kasperpeulen kasperpeulen removed their assignment Aug 4, 2023
@ndelangen ndelangen changed the base branch from next to release-8-0 November 28, 2023 11:57
@ndelangen ndelangen changed the title feat(addon): export interface PresetOptions Essentials: Export interface PresetOptions Nov 28, 2023
@ndelangen ndelangen merged commit 0bda657 into storybookjs:release-8-0 Nov 28, 2023
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants