-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: Regen lockfiles #24152
Merged
Merged
Maintenance: Regen lockfiles #24152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the error that was happening: ``` /Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/transpilers/swc.ts:262 throw new Error( ^ Error: @swc/core threw an error when attempting to validate swc compiler options. You may be using an old version of swc which does not support the options used by ts-node. Try upgrading to the latest version of swc. Error message from swc: Failed to deserialize buffer as swc::config::Options JSON: {"sourceMaps":true,"module":{"noInterop":false,"type":"commonjs","strictMode":true,"ignoreDynamic":false},"swcrc":false,"jsc":{"parser":{"syntax":"typescript","tsx":false,"dynamicImport":true,"importAssertions":true},"target":"es2020","transform":{"legacyDecorator":true,"react":{"throwIfNamespace":false,"useBuiltins":false}},"keepClassNames":true,"experimental":{"keepImportAssertions":true}}} Caused by: unknown field `keepImportAssertions`, expected one of `plugins`, `keepImportAttributes`, `emitAssertForImportAttributes`, `cacheRoot`, `disableBuiltinTransformsForInternalTesting` at line 1 column 395 at createVariant (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/transpilers/swc.ts:262:13) at createSwcOptions (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/transpilers/swc.ts:211:25) at create (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/transpilers/swc.ts:56:41) at createTranspiler (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/index.ts:784:16) at createTranspileOnlyGetOutputFunction (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/index.ts:1341:28) at createFromPreloadedConfig (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/index.ts:1404:34) at phase4 (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/bin.ts:543:44) at bootstrap (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/bin.ts:95:10) at main (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/bin.ts:55:10) at Object.<anonymous> (/Users/me/Projects/Storybook/core/scripts/node_modules/ts-node/src/bin.ts:800:3) ```
The error I was getting: ``` FAIL frameworks/angular/src/client/docs/angular-properties.test.ts ● Test suite failed to run Cannot find module 'zone.js/bundles/zone-testing-bundle.umd' from 'node_modules/jest-preset-angular/setup-jest.js' Require stack: node_modules/jest-preset-angular/setup-jest.js setup-jest.ts 1 | // eslint-disable-next-line import/no-extraneous-dependencies > 2 | import 'jest-preset-angular/setup-jest'; | ^ 3 | 4 | import { webcrypto } from 'node:crypto'; 5 | at Resolver._throwModNotFoundError (../../node_modules/jest-resolve/build/resolver.js:427:11) at Object.<anonymous> (node_modules/jest-preset-angular/setup-jest.js:1:103) at Object.<anonymous> (setup-jest.ts:2:1) ```
The error I was getting: ``` FAIL frameworks/angular/src/client/docs/angular-properties.test.ts ● Test suite failed to run Cannot find module 'zone.js/bundles/zone-testing-bundle.umd' from 'node_modules/jest-preset-angular/setup-jest.js' Require stack: node_modules/jest-preset-angular/setup-jest.js setup-jest.ts 1 | // eslint-disable-next-line import/no-extraneous-dependencies > 2 | import 'jest-preset-angular/setup-jest'; | ^ 3 | 4 | import { webcrypto } from 'node:crypto'; 5 | at Resolver._throwModNotFoundError (../../node_modules/jest-resolve/build/resolver.js:427:11) at Object.<anonymous> (node_modules/jest-preset-angular/setup-jest.js:1:103) at Object.<anonymous> (setup-jest.ts:2:1) ```
kasperpeulen
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
@swc/core
because of SWC: Reflect renamed keepImportAssertions configuration option TypeStrong/ts-node#2056This is the error that was happening with SWC upgraded:
I suspect that SWC will require node >16
zone.js
This is the error that was happening with the
zone.js
upgrade:Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
CI should pass, no manual testing required, I think.
Documentation
MIGRATION.MD
Checklist for Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>