-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move webpack to peer dependencies #556
Conversation
The changes work for me as well. I just had to provide my own webpack config: https://github.com/Zalastax/openschedule/blob/master/.storybook/webpack.config.js |
We can't make this a peer dep because, webpack doesn't installed by default with CRA. |
Can't you just change the installation instructions/getstorybook? I've seen a lot of libraries do that. |
If anyone wants these changes right now, you can try @arunoda Then maybe change require call to discover webpack dependency of parent package, if it exists? |
@Zalastax that's also a good idea to do that on the |
can we at least increase the range on the webpack direct dep? at least then deduping would allow this to work |
@jquense yep. That's something we could do now. |
Increase allowable webpack range, for folks using webpack 2, now webpack can be deduped in most cases so the users chosen version is used. related: storybookjs#556
just a heads up:
|
Thank you all, I hope we can do this fairly soon. I resolved the merge conflict, but this needs a very thorough review. |
Very similar to this #637 Thank you @sheerun for contributing, simply moving webpack to peerDependencies and allowing any version does not solve the problem we have with supporting webpack 2. Good news is it IS now also under consideration here: I need to do a great deal of testing on this. |
So don't feel bad or like this isn't going to happen, because it's likely going to happen SOON! I'm closing these PR because they will not be merged, because I'm doing them all in 1 swoop. |
This makes it possible to use react-storybook with webpack 2.
For now storybook will pass configuration from
.storybook/webpack.config.js
to webpack 1 even parent project specified webpack 2 as dependency. This makes storybook to re-use webpack version from parent project instead of introducing its own.It really works, I've tested it on my own project.