-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Include full URL in the "Copy Canvas Link" button #17498
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5a5c646. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! Minor comment inline
Can we get a review on this? It affects all Storybook users in a pretty obvious way. cc @yannbf Also, do we need the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @soso-15315 thank you so much for your contribution! It works great in all scenarios:
- Running Storybook in a local directory like localhost:4000/storybook
- Running in dev mode
- Running in served static from storybook-build
Thanks for making Storybook better 🚀
Issue: #15509
What I did
Add
location.origin
beforeiframe.html
How to test
If your answer is yes to any of these, please make sure to include it in your PR.