Addon-docs: Fix React Profiler in source snippets #19004
Conversation
+ test: fixed dead unit tests.
zhyd1997
changed the title
| @@ -101,6 +101,7 @@ export const renderJsx = (code: React.ReactElement, options: JSXOptions) => { | |||
| // To get exotic component names resolving properly | |||
| displayName: (el: any): string => | |||
| el.type.displayName || | |||
| (el.type === Symbol.for('react.profiler') ? 'Profiler' : null) || | |||
There was a problem hiding this comment.
the major change here!
| @@ -141,7 +142,7 @@ export const renderJsx = (code: React.ReactElement, options: JSXOptions) => { | |||
| return string; | |||
| }).join('\n'); | |||
|
|
|||
| return result.replace(/function\s+noRefCheck\(\)\s+\{\}/, '() => {}'); | |||
| return result.replace(/function\s+noRefCheck\(\)\s+\{\}/g, '() => {}'); | |||
There was a problem hiding this comment.
const Template: ComponentStory<typeof Button> = (args) =>
<Profiler id="test" onRender={() => console.log('test-profiler')}>
<Button {...args} />
</Profiler>
export const Primary = Template.bind({});
// More on args: https://storybook.js.org/docs/react/writing-stories/args
Primary.args = {
primary: true,
label: 'Button',
onClick: () => console.log('test-button')
};Before:
After:
There was a problem hiding this comment.
It still isn't showing the actual function. Is that the expected behavior?
| @@ -87,7 +87,7 @@ describe('Extracting Arguments', () => { | |||
| "control": Object { | |||
| "type": "boolean", | |||
| }, | |||
| "description": null, | |||
There was a problem hiding this comment.
@zhyd1997 — Can you please share why this change was necessary?
There was a problem hiding this comment.
I didn't change svelte code, and I think they 're all falsy value, so I just ran something like update-snapshots command.
There was a problem hiding this comment.
Previously we didn't enable code/renderers unit test after moved all source code into code folder, but I need run unit test for react, so I manually enabled it in this PR, but svelte unit test failed, that's why I updated all code/renders snapshots here.
I need to add a story to test it, |
|
Any news on this issue? It would be awesome if we can gave good code export functionality. Thank you! |
merge the latest upstream commits into this branch.
shilman
changed the title
|
Is this fix available in any version of |
Sorry no, available from this version: v7.0.0-alpha.46 |
Issue: #11554
What I did
code/renderersunit tests.How to test
If your answer is yes to any of these, please make sure to include it in your PR.