Convert @ts-ignore to @ts-expect-error #19122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove unused directives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Usage of
// @ts-ignorespread through the monorepo was potentially disabling type checks unnecessarily in some cases, potentially leading to unsafe code or bugs.What I did
Converted each
@ts-ignoreto@ts-expect-error. If there was already a comment, I kept it, otherwise I added(Converted from ts-ignore)because there's a lint rule to give a reason. Then, I ranyarn bootstrap --buildand removed the failing (unnecessary) disable directives until the build passed.Overall, this should improve type coverage and give a better pattern for other devs to follow.
How to test
CI