Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Svelte example #19549

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Delete Svelte example #19549

merged 4 commits into from
Oct 21, 2022

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Oct 19, 2022

This PR deletes the Svelte example now that all the repros have been set up.

It turns out none of the stories in the Svelte example where not already covered by our default repro stories, so there was nothing to migrate, only delete. At least from what I could tell.

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@JReinhold JReinhold self-assigned this Oct 19, 2022
@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Oct 19, 2022
@JReinhold JReinhold marked this pull request as draft October 19, 2022 20:41
@JReinhold
Copy link
Contributor Author

JReinhold commented Oct 19, 2022

@ndelangen @tmeasday I don't understand why the CI is failing here on the examples step. yarn build-storybooks --all exits 0 after 3 seconds, as if it couldn't find any examples and then it fails on persisting an empty dir.
But when I run it locally it builds plenty of Storybooks.

https://app.circleci.com/pipelines/github/storybookjs/storybook/30597/workflows/3e0f7273-d433-4092-bc3c-dd1024a0c506/jobs/429281

@tmeasday
Copy link
Member

@JReinhold you just need to decrement the parallelism of the examples step. I'll do that for you!

@JReinhold JReinhold marked this pull request as ready for review October 20, 2022 07:55
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmeasday tmeasday merged commit 3f77315 into next Oct 21, 2022
@tmeasday tmeasday deleted the jeppe/sb-544-svelte-example branch October 21, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants